IntersectionObserver polyfills not being served to Desktop+Mobile Safari >16.1
mq2thez opened this issue · comments
Hey folks, as part of this issue: #1192
This PR by @romainmenke was merged: https://github.com/Financial-Times/polyfill-library/pull/1231/files
I've just noticed during a deploy that with the release of Safari 16.1, we're back to seeing a significant spike in errors.
Would it be possible to update the numbers so that it serves for all versions of Safari until 17? I hate having to keep bothering folks every time Safari does a minor version bump.
@mq2thez Can you share anything about the volume of errors compared to previous Safari versions? Can you see an improvement with the changes that have shipped in Safari?
I am still curious what is going here :)
- new issue but looks the same as the old issue
- same issue and changes in WebKit/Safari had no/little effect
- same issue but we didn't find the true root cause before
Some samples of the user agent strings would also be useful.
@romainmenke in the last 14 days (which is as much data as I can easily access), we've been averaging 1k events per day. The spread is much more "Mobile Safari" than "Safari", but that lines up with our overall usage by browser. A random sample of several UA strings from events in the last hour:
Mozilla/5.0 (iPhone; CPU iPhone OS 16_1_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.1 Mobile/15E148 Safari/604.1
Mozilla/5.0 (iPhone; CPU iPhone OS 16_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.2 Mobile/15E148 Safari/604.1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.2 Safari/605.1.15
According to Sentry, it looks like maybe ~350 of the 1k events in the last 24 hours are from a device showing up as a Mac (assumed to be an iPad), which vaguely lines up with our usage numbers. It seems like maybe the number of errors is fewer, but since it's only coming from Safari 16.1.x and 16.2.x (whereas the previous numbers included errors from versions as far down as v13) I don't know that we can conclusively say that it has decreased.
This might be relevant : https://bugs.webkit.org/show_bug.cgi?id=249827
a.k.a same issue, not fully resolved yet
@mq2thez We have just released version 4.6.0 that sets the Safari version for IntersectionObserver to <17.0.
Hopefully the underlying issue will be resolved before then 🤞
Thank you!
Safari 17 has been out for a while and given that no new issues have been reported I am assuming that it is now really fixed 🤞