Jake-Short / swiftui-image-viewer

Image viewer built in SwiftUI for both local and remote images.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

import ImageViewer // <=== File 'ContentView.swift' is part of module 'ImageViewer'; ignoring import

mattyoung opened this issue · comments

Is the file ContentView.swift in you library code? I had to rename my test to something else to get it to compile.

And pinch out does zoom in but on release, the image snap back to its natural size. Is this how it suppose to work? I expect it to work like the Photo app: pinch zoom to stay at the zoom size.

The library itself (nor any of the dependencies it appears) have a ContentView.swift file, so your bug may be coming from somewhere else.

Also, yes, the pinch-to-zoom is meant to snap back to it's original size. I'll definitely take note of your suggestion though (feel free to make a new issue if you would like to get updated when that is released).

The library itself (nor any of the dependencies it appears) have a ContentView.swift file, so your bug may be coming from somewhere else.

The warning say ContentView.swift is the the ImageView module.

I just created a new project, added the package dependency. I cannot think of any reason on my end could be the cause.

Can you try doing the same and see? Make a new SwiftUI project, add your package and choose both local and remote. See if the same warning show?

@mattyoung Just tested on Xcode 12.4. Created a new project (SwiftUI + SwiftUI lifecycle), added swiftui-image-viewer (both remote and local), then ran it on iOS 14.4 iPhone 12 Pro simulator with no errors or warnings.

To try and reproduce this, could you share some more details, such as: Xcode version, lifecycle method, and any other necessary steps to reproduce.

Closing for inactivity.