Retrofit status code 2xx

Question

Retrofit status code 2xx

jaumard opened this issue 6 years ago · comments

Currently retrofit take all status as error except 200, it should take between 200 < 300 as a good response.
root cause is resty : https://github.com/Jaguar-dart/client/blob/master/resty/lib/src/jaguar_resty_base.dart#L387

Jimmy Aumard commented 6 years ago

fixed

Ravi Teja Gudapati · Answer 1 · Mon Nov 12 2018 23:35:57 GMT+0800 (China Standard Time)

Hi,

I purposefully changed it in this commit: 335fcd1

Do you want it changed back?

Jimmy Aumard · Answer 2 · Mon Nov 12 2018 23:38:13 GMT+0800 (China Standard Time)

Hi :)

Yes for me it was correct previously as say in the doc 2xx: These codes indicate success. The body section if present is the object returned by the request. It is a MIME format object. It is in MIME format, and may only be in text/plain, text/html or one fo the formats specified as acceptable in the request.

Jimmy Aumard · Answer 3 · Tue Nov 13 2018 17:50:14 GMT+0800 (China Standard Time)

@tejainece let me know when you revert and deploy this please :)
Thanks