JMoerman / Go-For-It

A stylish to-do list with built-in productivity timer.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Headerbar icons look somewhat awkward on Adwaita

jepotter1-archive opened this issue · comments

image

Notice that the hamburger menu icon is a bit blurry. Also, the back button is using the wrong icon, and it should be enclosed within a white button like in other GNOME applications (see for example: GNOME settings).

To Reproduce

  1. Set theme to Adwaita Light
  2. Delete all lists
  3. Restart application

Expected behavior

A nice headerbar that looks like that of other GTK+ applications under Adwaita and GNOME.

OS and application version:

  • Fedora Silverblue 33.20210220.0
  • GNOME 3.38.4 (Wayland)
  • Go For It 1.9.0 (Flatpak from Flathub)

8072646 should fix the arrow icon issue. 93fdb54 fixes the remaining issues. I would consider the blurriness issue an Adwaita bug: it should support both 16x16 and 24x24 for things like menu icons. I've worked around this by setting the icon size (menu and arrow) to 16x16 if Granite isn't used.

HB comp
The headerbar above shows the how the headerbar now looks (Adwaita, Gtk+ 3.22: so looks a bit different). The one below shows the headerbar when the elementary OS HIG is used (compile time switch) (elementary theme).

Nice! 😄 That was fast! Thank you!