IsaiahByDayah / use-prefer-dark-mode

Small react hook to determine if your user prefers dark mode on their system.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Doesn't work with React 17.x

RauliL opened this issue · comments

This hook doesn't seem to work with more recent versions of React. Rendering of the application fails and this is printed to the browser console:

Uncaught Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://fb.me/react-invalid-hook-call for tips about how to debug and fix this problem.

Yarn still happily installs this NPM package as dependency apparently because this dependency should contain <17.

I ended up creating my own version of the hook, which others working with React 17.x might find useful.

Oh, thanks for pointing this out. I'll try to get a PR in to fix things