IonicaBizau / ejs-playground

A web app to play with EJS templates.

Home Page:https://ionicabizau.github.io/ejs-playground/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

EJS Version

RyanZim opened this issue · comments

Is there a reason why this uses the old, unmaintained, EJS v1 (tj/ejs) instead of v2 (mde/ejs)? I was thinking maybe mde/ejs should link to this, but I see you're not using our version of the lib.

@RyanZim There is no specific reason. I coded this quite quickly to have a minimal app to play with. 😁
Basically, this link should be changed:

<script src="https://cdn.rawgit.com/tj/ejs/master/ejs.min.js"></script>

Linking it would be great! ✨

Yeah, should be https://npmcdn.com/ejs/ejs.min.js for the latest version (mde/ejs doesn't have the browser files in version control). Do you want to fix this yourself or should I submit a PR?

@RyanZim If you can fix it, that would be great! ✨

@IonicaBizau

Linking it would be great!

I've been wanting to do this but don't get time. Perhaps you could submit a PR to mde/ejs yourself? Feel free to mention me.

@RyanZim I was just busy with random projects, is it possible to do it for me? 😁

😆 Perhaps; I was just busy with random projects.

BTW, Here's my latest time-consumer: https://github.com/RyanZim/onessg.