Big ledger peer promotion ignored for too long.
coot opened this issue · comments
Marcin Szamotulski commented
cabal run ouroboros-network:sim-tests -- -p '/big ledger peers.progresses towards established target (from below)/' --quickcheck-tests 1000 +RTS -t -RTS
ouroboros-network:sim-tests
Ouroboros.Network.PeerSelection
progress
big ledger peers
progresses towards established target (from below): FAIL (1247.05s)
*** Failed! Falsified (after 194 tests and 341 shrinks):
GovernorMockEnvironment {peerGraph = PeerGraph [(PeerAddr 4,[],GovernorScripts {peerShareScript = Script (Nothing :| []), peerSharingScript = Script (Pe
erSharingDisabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])}),(PeerAddr 9,[],GovernorScripts {peerShareScript = Script (Nothing :| []), peerSharing
Script = Script (PeerSharingDisabled :| []), connectionScript = Script ((ToCooling,NoDelay) :| [(Noop,NoDelay)])}),(PeerAddr 13,[PeerAddr 29],GovernorScripts {pee
rShareScript = Script (Just ([PeerAddr 29],PeerShareTimeQuick) :| []), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoD
elay) :| [])}),(PeerAddr 27,[PeerAddr 13],GovernorScripts {peerShareScript = Script (Nothing :| [Just ([PeerAddr 13],PeerShareTimeQuick)]), peerSharingScript = Sc
ript (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])}),(PeerAddr 29,[PeerAddr 9],GovernorScripts {peerShareScript = Script (Nothing :
| [Just ([PeerAddr 9],PeerShareTimeQuick)]), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])})], localRoot
Peers = fromGroups [], publicRootPeers = fromList [(PeerAddr 4,(DoAdvertisePeer,IsLedgerPeer)),(PeerAddr 27,(DoAdvertisePeer,IsLedgerPeer))], bigLedgerPeers = fro
mList [PeerAddr 4], targets = Script ((PeerSelectionTargets {targetNumberOfRootPeers = 1, targetNumberOfKnownPeers = 1, targetNumberOfEstablishedPeers = 1, target
NumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0},ShortDelay) :
| [(PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 2, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumb
erOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0},NoDelay),(PeerSelectionTargets {targetNumberOfRo
otPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberO
fEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0},NoDelay),(PeerSelectionTargets {targetNumberOfRootPeers = 1, targetNumberOfKnownPeers = 4,
targetNumberOfEstablishedPeers = 3, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 1, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumb
erOfActiveBigLedgerPeers = 0},LongDelay),(PeerSelectionTargets {targetNumberOfRootPeers = 2, targetNumberOfKnownPeers = 4, targetNumberOfEstablishedPeers = 4, tar
getNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 1, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0},LongDelay)
,(PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumber
OfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0},NoDelay),(PeerSelectionTargets {targetNumberOfRoot
Peers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 1, targetNumberOfE
stablishedBigLedgerPeers = 1, targetNumberOfActiveBigLedgerPeers = 0},NoDelay)]), pickKnownPeersForPeerShare = Script (PickFirst :| []), pickColdPeersToPromote =
Script (PickFirst :| []), pickWarmPeersToPromote = Script (PickFirst :| []), pickHotPeersToDemote = Script (PickFirst :| []), pickWarmPeersToDemote = Script (Pick
First :| []), pickColdPeersToForget = Script (PickFirst :| []), peerSharing = PeerSharingEnabled}
Signal key: (target, known big ledger peers, established big ledger peers, recent failures, opportunities, ignored too long)
Last 20 signal values:
Time 35990s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35990s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Time 35991s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35991s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Time 35992s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35992s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Time 35993s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35993s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Time 35994s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35994s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Time 35995s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35995s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Time 35996s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35996s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Time 35997s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35997s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Time 35998s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35998s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Time 35999s : (1,fromList [PeerAddr 4],fromList [PeerAddr 4],fromList [],fromList [],fromList [])
Time 35999s : (1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [])
Property violated at: Time 36009s
Invalid signal value:
(1,fromList [PeerAddr 4],fromList [],fromList [],fromList [PeerAddr 4],fromList [PeerAddr 4])
Use --quickcheck-replay=331621 to reproduce.