Scroll indicator is shown for `<view trigger="refresh" scroll="true" shows-scroll-indicator="false"/>`

[Charles Johnson]

trigger="refresh" wraps a ScrollView without taking into account the shows-scroll-indicator attribute

I think this code in src/core/hyper-ref/index.tsx needs changing to fix this bug

ScrollableView = ({ children }: { children: JSX.Element }): JSX.Elem
  const behaviors = this.getBehaviorElements(TRIGGERS.REFRESH);
  if (!behaviors.length) {
    return children;
  }
  const refreshHandlers = behaviors.map(behaviorElement =>
    Behaviors.createActionHandler(behaviorElement, this.props.onUpda
  );
  const onRefresh = () => refreshHandlers.forEach(h => h(this.props.
  const refreshControl = React.createElement(RefreshControl, {
    onRefresh,
    refreshing: this.state.refreshing,
  });
  return React.createElement(
    ScrollView,
    { refreshControl, style: this.getStyle() },
    children,
  );
};

[Charles Johnson]

I think I can use this.props.element.getAttribute('shows-scroll-indicator') to determine the showsVerticalScrollIndicator prop for the ScrollView

[Charles Johnson]

I tested changing the above code to this which fixed the issue:

ScrollableView = ({ children }: { children: JSX.Element }): JSX.Element => {
  const behaviors = this.getBehaviorElements(TRIGGERS.REFRESH);
  if (!behaviors.length) {
    return children;
  }
  const refreshHandlers = behaviors.map(behaviorElement =>
    Behaviors.createActionHandler(behaviorElement, this.props.onUpdate),
  );
  const onRefresh = () => refreshHandlers.forEach(h => h(this.props.element));
  const refreshControl = React.createElement(RefreshControl, {
    onRefresh,
    refreshing: this.state.refreshing,
  });
  return React.createElement(
    ScrollView,
    {
      refreshControl,
      showsVerticalScrollIndicator:
        this.props.element.getAttribute('shows-scroll-indicator') !== 'false',
      style: this.getStyle(),
    },
    children,
  );
};

[Florent Bonomo]

Good catch @Charles-Johnson ! thanks for spending the time investigating the issue. Could you submit your bug fix in a pull request?

[Charles Johnson]

No problem @flochtililoch ! I've submitted the pull request

[Florent Bonomo]

Resolved by #819