Instawork / hyperview

Server-driven mobile apps with React Native

Home Page:https://hyperview.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Example app: Scroll to list item doesn't work

Invertisment opened this issue · comments

I'm on commit aeed0cd.
I ran it on Android AVD.

When I open the example app and navigate to
Advanced behaviors -> Scroll -> List -> Scroll to item 15 (all text buttons don't work)
Then nothing happens.

All scroll buttons do nothing, even the scroll to top ones.

@flochtililoch something to look into, I believe you added scroll-to-item support?

it looks like this got broken during our TS migration, and the issue in particular seem to be related to the DocContext which hasn't been properly updated in list / sectionlist components.
@hgray-instawork, since you have some pending work that's refactoring the doc context, could you validate the issue is fixed in your branch and report back? Thanks!
On a side note, we'll need to figure out why TS is not surfacing the typing issue here.

I have confirmed that this is working as expected in the next release candidate which is going through testing now and should be released shortly.

This fix has been released in version 0.74.0 of Hyperview.