useless creation of crawl_profile_with_login.py
imansh77 opened this issue · comments
@timmoh are you sure it is a good approach to have two way? because we have login_username in settings.py and again in this file we have settings.login_username and even in original crawl_porfile.py I think it makes user confuse and harder to maintain that's enough having one it does the job.
Originally posted by @imansh77 in https://github.com/timgrossmann/instagram-profilecrawl/commit_comment/create#commitcomment-31796469
what's the problem?
by default python would use the login_username in settings.py ... if you want to overwrite it for a single script you could overwrite (like every setting) with settings.login_username
@timmoh yeah but I mean why do we need a new file when settings.py do the thing
crawl_profile_with_login.py is just an example file like all other file beginning with "crawl_profile...."
don't you think it'll make confusion?
@imansh77 perhaps we should set up an folder "examples" and move this file to there