Fullscreen button does not work

Question

Fullscreen button does not work

PaulHax opened this issue 9 months ago · comments

The fullscreen button does not work.

Works in https://github.com/InsightSoftwareConsortium/itk-viewer-bootstrap-ui

Probably need to add allow="fullscreen" to the iframe:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#allowfullscreen

Paul Elliott · Answer 1 · Mon Nov 20 2023 04:39:02 GMT+0800 (China Standard Time)

Given imjoy docs
https://github.com/imjoy-team/ImJoy/blob/c255d9cda9dc19d441fb7cf1eaca806e5ec71af8/docs/development.md#permissions

I tried this: PaulHax@a796f03

But did not work. Maybe we can querySelector() in python for the iframe and set allow="fullscreen"?

Matt McCormick · Answer 2 · Fri Dec 01 2023 04:18:50 GMT+0800 (China Standard Time)

CC @bnmajor @oeway

Wei Ouyang · Answer 3 · Fri Dec 01 2023 05:46:33 GMT+0800 (China Standard Time)

Hi I just checked, it appears that it's not possible to request fullscreen from within the iframe itself, the fullscreen should be done in the host window. This means we need to implement it in python as suggested by @PaulHax . And we might need to still add allow="fullscreen" to the iframe as I understand.