Fullscreen button does not work
PaulHax opened this issue · comments
The fullscreen button does not work.
Works in https://github.com/InsightSoftwareConsortium/itk-viewer-bootstrap-ui
Probably need to add allow="fullscreen"
to the iframe:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#allowfullscreen
Given imjoy docs
https://github.com/imjoy-team/ImJoy/blob/c255d9cda9dc19d441fb7cf1eaca806e5ec71af8/docs/development.md#permissions
I tried this: PaulHax@a796f03
But did not work. Maybe we can querySelector()
in python for the iframe and set allow="fullscreen"?
Hi I just checked, it appears that it's not possible to request fullscreen from within the iframe itself, the fullscreen should be done in the host window. This means we need to implement it in python as suggested by @PaulHax . And we might need to still add allow="fullscreen"
to the iframe as I understand.