Update conda package
brey opened this issue · comments
The conda package supports only python <= 3.8. In order to update, afaik, the upstream path starts from itk.
Please check and accept conda-forge/itk-feedstock#36 so that the work on the itkwidgets update can continue.
Otherwise, could you please provide a roadmap for updating the conda option.
Thanks
@brey is it possible to help update the conda package to the 1.0aX version? This removes the direct dependency on itk.
@thewtex I can give it a try. However, I see itk in the environment.yml even for 1.0aX version. How is it that the dependency is avoided?
@thewtex It seems that itkwasm, imjoy and ngff all lack a conda package. It shouldn't be difficult to create one for them using npm and/or the pip package. If you are ok with it, I could give it a try.
However, in the meantime and just to make sure that I can use itkwidgets in my next release, can you merge the itk PR above so that I can build the 0.32.x version?
merge the itk PR above
Done -- thank you so much!
I could give it a try.
Yes -- thank you! You are doing amazing work, @brey 👏
Thanks @thewtex. I would suggest that you merge now the PRs that the bot made in itkwidget-feedstock here. This way my immediate problem would be solved since the same version I am using in py3.8 would be available for py3.11.
I will then make a PR for the latest 0.32.x version (if the bot doesn't bit me to it).
After that, the bot should take care of future releases if any.
I will then work on the 1.0.a26 dependencies. If I manage to build it locally, I can push it, when it's time, on the feedstock to replace the current recipe. I assume that once version 1 is released there will be no more 0.32.x releases.
Cheers
merge now the PRs that the bot made in itkwidget-feedstock here
Done.
Are you willing to be added as a maintainer on these feedstocks?
I will then make a PR for the latest 0.32.x version (if the bot doesn't bit me to it).
I will then work on the 1.0.a26 dependencies.
Thank you!
I assume that once version 1 is released there will be no more 0.32.x releases.
Correct.
@thewtex I have used the bot to update the version to the latest. You can merge conda-forge/itkwidgets-feedstock#56 for completing the process.
Also thanks for the invitation to become a maintainer but I can help either way and my plate is full with the maintenance of my packages.
I will work on the new version as discussed and let you know. We can leave this issue open in order to communicate about it.
@thewtex It took me awhile to figure out that version 0.32.x doesn't work with traitlets>5.6.0. I have also seen since that you have also pinned ipydatawidgets<4.3.3.
If these are here to stay we should include them in the conda recipe to avoid issues like those I had.
Let me know.
@brey yes, makes sense.