Add packaging to generate binary distributables
tomcl opened this issue · comments
electron-packager will do basic packaging, but due to an issue with monaco-editor and webpack a fix is needed.
Basically, copying ./node_modules/monaco-editor/min to the equivalent place under app/resources and adjusting the reference to the monaco loader.js under ./app/index.html so that it can pick up the files it needs that are not (because it is non-standard) automatically packaged.
- The yarn pakage script needs to be adjusted to do this copy before running electron-package.
- The distributed binaries need checking on different systems
- It would be nice (but not needed) to add an msi packager, e.g. as electron-forge provides.
I've now added the boilerplate to allow electron-packager to work.
yarn run package will generate the binaries (they are quite big).
Binaries are under ./dist/<os-name> I've tested the Windows distribution which works fine. NO GUARANTEE that other distros work,
Help needed to sort these out: add to this issue if you do this. Issue will be closed when all distributions are working OK.
In addition: it would be nice to package the Windows distro as an MSI file. electron-forge should theoretically be able to do this. Assuming it works...
I've added a batch file to run packager in admin mode - I hope this will fix the OS-X binaries not working: please could anyone running Visual2 from binaries under OS-X let me know?
OSX binary seems to be working at first glance, compiled from an OSX host.
OK, thanks. I'll close this for now.