IgniteUI / ignite-ui

Ignite UI for jQuery by Infragistics

Home Page:https://bit.ly/2kuu1fT

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[igNotifier] incorrect return type of `isVisible` method

tkiryu opened this issue · comments

Description

I ran into a TypeScript check error when I implement like below.

    const $notifier = $('#notifier');

    if ($notifier.igNotifier('isVisible')) { // <- error
        // do something
    }

I found TypeScript definition file defines that isVisible method returns void.

// @types/ignite-ui@18.2.0 index.d.ts 
interface JQuery {
	igNotifier(methodName: "changeLocale"): void;
	igNotifier(methodName: "notify", state: Object, message?: string): void;
	igNotifier(methodName: "isVisible"): void;
        ...

Steps to reproduce

Implement like below.

    const $notifier = $('#notifier');

    if ($notifier.igNotifier('isVisible')) {

    }

Result

An error occur.

Expected result

An error should not occur.

Attachments

None

@SlavUI
Do you know when we will update the npm package that includes this fix?
CC: @tkiryu

@bazal4o do you have idea when will this be available ?

@SlavUI @ymita The fix is already available in the SRs. It will be available in the 19.1 RTM as well.