Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.

Home Page:https://wolvic.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can't bookmark pages that don't have a <title> tag or have an empty <title> tag.

Kate6 opened this issue · comments

Configuration

Wolvic version: 1.6.1
Wolvic build ID:

Hardware: Meta Quest 2

Steps to Reproduce

  1. Visit a page that has an empty <title> tag or doesn't have a <title> tag.
  2. Click the little star icon next to the address bar to bookmark the page.
  3. Click the "Library" icon on the Wolvic toolbar and bring up the bookmarks.

Current Behavior

When bookmarking a page that either doesn't have a <title> tag or has an empty <title> tag, the little star icon does fill in to indicate that the page has been bookmarked, but the page does not actually appear in the list of bookmarks.

Expected Behavior

I would expect pages without a <title> tag or with an empty <title> tag to still appear in bookmarks, perhaps by their URL instead of by the page title.

Possible Solution

Context

Error Logs and Stack Traces

Thanks @Kate6 for the report. Any actual page in the wild that could serve as an example? Otherwise we'd just use a local one.

The pages I encountered this with were actually all parts of little LAN-local applets I'd written for my own personal use. Once I realized this was why they weren't showing up in Wolvic's bookmarks I actually went through and changed them all to have non-empty <title> tags, which solved the problem for me personally.

Still seemed like a definite bug though so I thought I'd report it.

The title tag is an important and obligatory part of the website structure. As a solution, I can recommend adding a bookmark to another resource and changing the link

As per the HTML standard, "If it's reasonable for the Document to have no title, then the title element is probably not required."