Run ESLint and Typecheck on CI and use pnpm

Question

Run ESLint and Typecheck on CI and use pnpm

andresgutgon opened this issue 5 months ago · comments

Andrés commented 5 months ago

What?

Not really an issue. But a piece of feedback 😃

CI lint & Typecheck

While working in this PR #124 I noticed CI is not running Linter or Typescript checks.

Is there any reason for that?

Also notice ESLint config is a big convoluted with double tsconfig.json and tsconfig.lint.json in all the packages. I think this could be simplified.

Use PNPM instead of NPM

I admit this one is not critical 😂 . But I've working in all my monorepos with pnpm is so much better experience. Faster builds and better module resolution.

Ido Pesok · Answer 1 · Sun Jun 23 2024 02:55:18 GMT+0800 (China Standard Time)

Good catch on the checks, just added turbo typecheck to the CI. Will work on running the linter.

With regards to the ESLint config, this is what turborepo recommends in their examples

Going to move this issue to feedback category in the new discussions page.