IceDBorn / cinny

Yet another matrix client

Home Page:https://cinny.in

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Minor bug - Call unexpected reconnect if home screen is empty

cspark-development opened this issue · comments

Describe the bug

Hi there IceDBorn,

Hope you are well, I tested your fork with implemented jitsi calling for Cinny on https://cinny.alfonso.top/ and am pleased how well it works, excellent work! It is perfectly usable aside from minor bugs.

There is an unexpected reconnect to the jitsi call if the home screen is empty, please see steps to reproduce.

If you need any further info please let me know,

Thanks,

Spacur

Reproduction

  1. Ensure that your home section has no text channels or voice channels whatsoever therefore ensuring that you receive the "Welcome to Cinny" splash screen.
  2. Create a voice channel within a pinned space.
  3. Join said voice channel.
  4. Disconnect from voice channel.
  5. Navigate back to Home section. (Does not matter if you navigate to text channels or direct messages as an intermediate step)
  6. You will rejoin the voice channel without any warning, it will take up all the space where the splash screen is expected. The splash screen does not appear to be visible in the background.

Expected behavior

  1. Ensure that your home section has no text channels or voice channels whatsoever therefore ensuring that you receive the "Welcome to Cinny" splash screen.
  2. Create a voice channel within a pinned space.
  3. Join said voice channel.
  4. Disconnect from voice channel.
  5. Navigate back to Home section.
  6. You are greeted with the standard "Welcome to Cinny" splash screen.

Platform and versions

1. OS: Windows 10 (22H2)
2. Browser: Librewolf (Firefox 114.0.1-2)
3. Cinny Version: Fork provided at https://cinny.alfonso.top/ on 08/08/2023
4. Matrix Homeserver: matrix.org

Additional context

I understand eventually that the Cinny developers will implement voice calling in their way and natively with Matrix's VOIP features, however despite several months since your fork it appears no certainty as of when. Right now your fork is 95% viable for use as a temporary workaround which is excellent and it seems a little more work would make it 100% viable.

I'm not that familiar with web technologies but when I can I'll take a look into this further.