Regex Need to be modified

Question

Regex Need to be modified

uganjha opened this issue 8 years ago · comments

uganjha commented 8 years ago

CSVRE.java has issue

*""([^\"]+?)",?|([^,]+),?|," * reg-ex can not match occurrence where if any column of csv has no value.

Like ,,,,,"0",,"0","0",,,"12/13/2015 12:10:00 AM","2.94","12/13/2015 12:10:00 AM","13.69"

so it should be ""([^\"]?)",?|([^,]),?|,"

Ian Darwin · Answer 1 · Thu Apr 14 2016 00:55:47 GMT+0800 (China Standard Time)

Thanks. Busy with Android Cookbook now, will get this tested and installed after that.

Ian Darwin · Answer 2 · Sat Oct 08 2016 03:58:41 GMT+0800 (China Standard Time)

Did you run the tests? Your change breaks a bunch of CSVRETests, not just the one with the empty field, so I think it's not as simple as your first attempt. Maybe a non-greedy match will be better?