comparison checks in rhub & win-builder
wibeasley opened this issue · comments
Will Beasley commented
The following error appears in rhub, but not in any local test or on travis. I'm guessing it's related to either encoding or line character?
Last 13 lines of output:
1/1 mismatches
x[1]: "number,player,position,height,weight,dob,country_birth,experience_years,c
x[1]: llege of Louisiana\r\n1,Randy Brown,PG,6-2,190,\"May 22, 1968\",us,5,\"Hou
x[1]: ston,�New Mexico State\"\r\n6,Matt Steigenga,SF,6-7,225,\"March 27, 1970\"
x[1]: ,us,0,Michigan State\r\n7,Toni Kukoc,SF,6-10,192,\"September 18, 1968\"...
y[1]: "number,player,position,height,weight,dob,country_birth,experience_years,c
y[1]: ollege\r\n0,Robert Parish,C,7-0,230,\"August 30, 1953\",us,20,Centenary Co
x[1]: ollege\r\n0,Robert Parish,C,7-0,230,\"August 30, 1953\",us,20,Centenary Co
y[1]: llege of Louisiana\r\n1,Randy Brown,PG,6-2,190,\"May 22, 1968\",us,5,\"Hou
y[1]: ,us,0,Michigan State\r\n7,Toni Kukoc,SF,6-10,192,\"September 18, 1968\"...
y[1]: ston,�New Mexico State\"\r\n6,Matt Steigenga,SF,6-7,225,\"March 27, 1970\"
and win-builder:
Using Dataverse server `demo.dataverse.org`.
== Failed tests ================================================================
-- Failure (tests-get_dataframe-original-basketball.R:19:3): roster-by-name ----
`actual` not equal to `expected_file`.
1/1 mismatches
x[1]: "number,player,position,height,weight,dob,country_birth,experience_years,c
x[1]: ollege\r\n0,Robert Parish,C,7-0,230,\"August 30, 1953\",us,20,Centenary Co
x[1]: llege of Louisiana\r\n1,Randy Brown,PG,6-2,190,\"May 22, 1968\",us,5,\"Hou
x[1]: ston,�New Mexico State\"\r\n6,Matt Steigenga,SF,6-7,225,\"March 27, 1970\"
x[1]: ,us,0,Michigan State\r\n7,Toni Kukoc,SF,6-10,192,\"September 18, 1968\"...
y[1]: "number,player,position,height,weight,dob,country_birth,experience_years,c
y[1]: ollege\r\n0,Robert Parish,C,7-0,230,\"August 30, 1953\",us,20,Centenary Co
y[1]: llege of Louisiana\r\n1,Randy Brown,PG,6-2,190,\"May 22, 1968\",us,5,\"Hou
y[1]: ston,�New Mexico State\"\r\n6,Matt Steigenga,SF,6-7,225,\"March 27, 1970\"
y[1]: ,us,0,Michigan State\r\n7,Toni Kukoc,SF,6-10,192,\"September 18, 1968\"...
-- Failure (tests-get_dataframe-original-basketball.R:36:3): roster-by-doi -----
`actual` not equal to `expected_file`.
1/1 mismatches
x[1]: "number,player,position,height,weight,dob,country_birth,experience_years,c
x[1]: ollege\r\n0,Robert Parish,C,7-0,230,\"August 30, 1953\",us,20,Centenary Co
x[1]: llege of Louisiana\r\n1,Randy Brown,PG,6-2,190,\"May 22, 1968\",us,5,\"Hou
x[1]: ston,�New Mexico State\"\r\n6,Matt Steigenga,SF,6-7,225,\"March 27, 1970\"
x[1]: ,us,0,Michigan State\r\n7,Toni Kukoc,SF,6-10,192,\"September 18, 1968\"...
y[1]: "number,player,position,height,weight,dob,country_birth,experience_years,c
y[1]: ollege\r\n0,Robert Parish,C,7-0,230,\"August 30, 1953\",us,20,Centenary Co
y[1]: llege of Louisiana\r\n1,Randy Brown,PG,6-2,190,\"May 22, 1968\",us,5,\"Hou
y[1]: ston,�New Mexico State\"\r\n6,Matt Steigenga,SF,6-7,225,\"March 27, 1970\"
y[1]: ,us,0,Michigan State\r\n7,Toni Kukoc,SF,6-10,192,\"September 18, 1968\"...
-- Failure (tests-get_dataframe-original-basketball.R:53:3): roster-by-id ------
`actual` not equal to `expected_file`.
1/1 mismatches
x[1]: "number,player,position,height,weight,dob,country_birth,experience_years,c
x[1]: ollege\r\n0,Robert Parish,C,7-0,230,\"August 30, 1953\",us,20,Centenary Co
x[1]: llege of Louisiana\r\n1,Randy Brown,PG,6-2,190,\"May 22, 1968\",us,5,\"Hou
x[1]: ston,�New Mexico State\"\r\n6,Matt Steigenga,SF,6-7,225,\"March 27, 1970\"
x[1]: ,us,0,Michigan State\r\n7,Toni Kukoc,SF,6-10,192,\"September 18, 1968\"...
y[1]: "number,player,position,height,weight,dob,country_birth,experience_years,c
y[1]: ollege\r\n0,Robert Parish,C,7-0,230,\"August 30, 1953\",us,20,Centenary Co
y[1]: llege of Louisiana\r\n1,Randy Brown,PG,6-2,190,\"May 22, 1968\",us,5,\"Hou
y[1]: ston,�New Mexico State\"\r\n6,Matt Steigenga,SF,6-7,225,\"March 27, 1970\"
y[1]: ,us,0,Michigan State\r\n7,Toni Kukoc,SF,6-10,192,\"September 18, 1968\"...
[ FAIL 3 | WARN 0 | SKIP 0 | PASS 85 ]