Makefile for samples need to work in both product and open-source

Question

Makefile for samples need to work in both product and open-source

chanskw opened this issue 10 years ago · comments

Problem reported from Inet, but still valid here:

The Makefiles in $STREAMS_INSTALL/samples/com.ibm.streamsx.inet/HTTPStreamRead as well as the InetSource and InetSourceDynamicURL samples all use this definition to specify the location of the toolkit:

STREAMS_INET_TOOLKIT ?=../../com.ibm.streamsx.inet

However, the relative path to the toolkit from those directories is actually this:
../../../toolkits/com.ibm.streamsx.inet

So, "make" fails with the toolkit not being found.

toolkit path should be set to:
STREAMS_INET_TOOLKIT ?=../../com.ibm.streamsx.inet:${STREAMS_INSTALL}/toolkits/com.ibm.streamsx.inet

Samantha Chan · Answer 1 · Thu Feb 12 2015 12:35:49 GMT+0800 (China Standard Time)

Marking as must-fix so we can find later.. not really a must-fix for product.

Samantha Chan · Answer 2 · Thu Feb 12 2015 12:43:17 GMT+0800 (China Standard Time)

To be fixed at next possible chance.

Kris Hildrum · Answer 3 · Fri Feb 13 2015 02:44:15 GMT+0800 (China Standard Time)

I pushed a fix (affecting only the samples in the samples directory, not the extra samples or the test apps) to the toolkitlocation branch