ESLINT errors not solvable without refactoring

Question

sanjeevghimire opened this issue 6 years ago · comments

Please lint the javascript code and make sure travis passes when linting. Example of issues are:

Steve Martinelli · Answer 1 · Fri Jul 27 2018 09:22:18 GMT+0800 (China Standard Time)

Steve Martinelli · Answer 2 · Fri Jul 27 2018 09:44:41 GMT+0800 (China Standard Time)

@sanjeevghimire what do you think of #6 ?

Sanjeev Ghimire · Answer 3 · Fri Jul 27 2018 10:48:08 GMT+0800 (China Standard Time)

#6 fixes the spacing issue but not object referenced issues. if we hook eslint with travis, it will complain.

Steve Martinelli · Answer 4 · Fri Jul 27 2018 11:55:41 GMT+0800 (China Standard Time)

@sanjeevghimire i created PR #8 too, just poking around with eslint.

Hi @ptrikkur can you look at #6 and #8

ptrikkur · Answer 5 · Mon Jul 30 2018 21:03:39 GMT+0800 (China Standard Time)

@stevemart I merged both #6 and #8 . I took the resulting script.js and linted it. I got one error.

1:5 error Parsing error: Unexpected token conversationContext

✖ 1 problem (1 error, 0 warnings)

Sanjeev Ghimire · Answer 6 · Tue Jul 31 2018 21:33:49 GMT+0800 (China Standard Time)

@ptrikkur I have fixed the linting issues. I have also removed few unused functions, if you can review it as well that would be great. #9

Sanjeev Ghimire · Answer 7 · Wed Oct 03 2018 04:56:31 GMT+0800 (China Standard Time)

i think this is fixed. closing it.