Giters

IBM / network-config-analyzer

A semantic analyzer for resources that configure network connectivity (e.g., Kubernetes NetworkPolicy).

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix "src_peers" and "dst_peers" dimensions comparisons

tanyaveksler opened this issue · comments

commented

The src_peers and dst_peers dimensions are special dimensions, they do not have constant domain. Their domain depends on the current set of peers in the system (as appears in BasePeerSet singleton). This set grows when adding more configurations. Thus, there is no unique 'all values' representation. In particular, those dimensions are never reduced to inactive.
This might be a problem in comparison and inclusion operators of ConnectivityProperties. The possible solution may be to keep 'reference full domain value' for these dimensions (as another member in the BasePeerSet), and to set it to relevant values per query, while making a special treatment of these dimensions in the above comparison and inclusion operators.