Tutorial 14: Parameter "tile_size" is not passed down to proper function.

Question

Tutorial 14: Parameter "tile_size" is not passed down to proper function.

d4ichi opened this issue 5 years ago · comments

Daichi K. commented 5 years ago

14_DeepDream.ipynb

Function "optimize_image" is calling "tiled_gradient":

tiled_gradient(gradient=gradient, image=img)

But I believe this should be something like:

tiled_gradient(gradient=gradient, image=img, tile_size=tile_size)

No matter we set tile_size in "recursive_optimize", that parameter is not passed down to proper function, i think.

Could you check this out please.
Thanks.

Hvass-Labs · Answer 1 · Wed Jan 02 2019 20:38:23 GMT+0800 (China Standard Time)

It has been over 2 years since I did this so I honestly can't remember. But I looked at it briefly and it appears you might be right, that the tile_size parameter is not passed from the optimize_image() function when it calls tiled_gradient(). Could you try and change it and report back here what happens? Do you get an error if you change the tile_size?

Hvass-Labs · Answer 2 · Sun Jan 13 2019 01:49:54 GMT+0800 (China Standard Time)

Thanks for reporting this. It has now been fixed. There does seem to be a difference in the images that are produced depending on the tile-size.

Daichi K. · Answer 3 · Sun Feb 17 2019 05:19:40 GMT+0800 (China Standard Time)

I'm sorry, it seems I missed notification, didn't realize your comment. Thank you so much for fixing this, also thank you again for this awesome repo.