Giters

HubertD / cangaroo

open source can bus analyzer software

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

(minor) compiler warning, enum value outside "int" range

fenugrec opened this issue · comments

commented

Hi,

just a fairly benign warning from candle.h :

candle/candle.h:47:26: warning: ISO C restricts enumerator values to range of ‘int’ [-Wpedantic]
   47 |     CANDLE_ID_EXTENDED = 0x80000000,

Of course 0x80000000 typically translates to a negative int32 value on pretty much all platforms. I see this enum is simply used as unshifted bitmasks so it's fairly safe, but I would suggest changing it to simple #define values anyway. Since the enum was anonymous anyway and not used as a type, I don't think there is any disadvantage ?