Giters

HubSpot / hubspot-api-php

HubSpot API PHP Client Libraries for V3 version of the API

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect Annotation

sylfabre opened this issue · comments

commented

Hello

I found out that the lifecycle property can be null so HubSpot\Client\Crm\Companies\Model\SimplePublicObjectWithAssociations::getProperties() may not always return an array of strings.

=> The method's annotation is incorrect: https://github.com/HubSpot/hubspot-api-php/blob/master/codegen/Crm/Companies/Model/SimplePublicObjectWithAssociations.php#LL287C31-L287C31

It should be @return array<string,string|null>.

It's important for me as it fails my static analysis run in my CI

Thanks!