HubSpot / drop

A library for creating dropdowns and other floating elements. #hubspot-open-source

Home Page:http://github.hubspot.com/drop/docs/welcome

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cannot read property of 'getAttribute' of null

Z6n4 opened this issue · comments

commented

Occurs in version 1.4.3 in drop.js, line 178
Uncaught TypeError: Cannot read property 'getAttribute' of null [drop.js:178]

The stack trace on my page starts with jQuery, into drop, and then DropInstance.
I did not think this was dependent on jQuery.

It is also failing on your demo page, when I try to "run" the first to blocks that have a run button.

commented

So i dug into this a bit further which was not too hard, and realized I probably provided a bad selector for the target option.

However, the error handling for this is not firing.
if (typeof this.target === 'undefined') {
throw new Error('Drop Error: You must provide a target.');
}

This is in the latest version of google chrome.

commented

you are likely have an Array of HTMLElements in the selector, not one.

Can this be closed?