HiFi-LoFi / FFTConvolver

Audio convolution algorithm in C++ for real time audio processing

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issue with naive vs FFT convolver test?

marcel303 opened this issue · comments

Hi,

Shouldn't the line:
if (relError > relTolerance && absError > absTolerance)

Over here,

if (relError > relTolerance && absError > absTolerance)

Read:
if (relError > relTolerance || absError > absTolerance)

Right now it fails if and only if both fail. Isn't it expected the test fails if either absolute or relative error exceeds the threshold? (so logical or should be used).

There is another similar test in the same file by the way.

Regards,
Marcel