Giters

HewlettPackard / oneview-golang

Golang bindings for OneView api's

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ServerHardware #GetServerHardwareList Issues

jsmartt opened this issue · comments

commented

In ServerHardware #GetServerHardwareList, I think there are a few issues:

  1. The REST here call doesn't handle errors
  2. This section doesn't appear to do anything useful (does it?). Maybe it was left in after a refactor?
  3. Unmarshalling the data doesn't set the Client property, so many subsequent calls on the objects returned (e.g. PowerOff()) will fail unless you set the Client property manually.
commented

#115 Issue has been fixed in this PR

commented

The fix for this issue is provided in #137.
Closing this issue now. Feel free to reopen if the issue still exists.