Animation doesn't work when navigationController pushing screen

Question

Animation doesn't work when navigationController pushing screen

ZHNursultan opened this issue 2 years ago · comments

Why Hero Transition Animation doesn't work when I push a new viewController into UINavigationController or setting as a root view controller?

Joe Mattiello · Answer 1 · Tue Nov 15 2022 10:34:22 GMT+0800 (China Standard Time)

Gonna need a little more info.

Sample code?

Nursultan · Answer 2 · Mon Nov 21 2022 20:52:34 GMT+0800 (China Standard Time)

@JoeMatt of course sorry for late answer
It works if I present it. But doesn't if I push.

let onboarding2 = Onboarding2ViewController(viewModel: .init())
onboarding2.hero.isEnabled = true
router.push(onboarding2)

router is UINavigationController
router.push(onboarding2) is animated true
router is hero enabled true

niralishaha25 · Answer 3 · Thu Dec 01 2022 20:50:43 GMT+0800 (China Standard Time)

I am facing same issue on iOS 16

Joe Mattiello · Answer 4 · Sat Dec 03 2022 11:55:01 GMT+0800 (China Standard Time)

Unfortunately, my time/role on this project is more as a project manager.

If anyone can debug and write a fix, even something that needs some cleanup, I'd be more than happy to test and merge or improve. Still, I don't have the cycles with all my other projects to debug this at the moment, especially since I'm not using Hero myself as my main apps have moved over to SwiftUI.