Herb-AI / HerbSearch.jl

Search procedures and synthesizers for Herb.jl

Home Page:https://herb-ai.github.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Renaming solver related functions/variables

Whebon opened this issue · comments

Some names need to be more concise and/or more descriptive. Candidates for renaming:

  • StateFixedShapedHole
  • shouldschedule
  • mark_feasible (should have the indicator for mutability !, and 'mark' might be a bit unconventional)
  • DomainRuleNode
  • FixedShapedSolver (name comes from FixedShapedHole + Solver, but the solver itself is not fixed shaped)
  • FixedShapedIterator (name comes from FixedShapedHole + ProgramIterator, but the iterator itself is not fixed shaped)
  • get_node_path
  • VarNode
  • remove_all_but!

Outcome from brainstorming:

✅ = leave as-is

  • StateFixedShapedHole -> StateHole
  • shouldschedule -> ✅
  • mark_feasible -> set_infeasible!
  • DomainRuleNode -> DomainNode
  • FixedShapedSolver -> UniformTreeSolver
  • FixedShapedIterator ✅ (but remove after Bart's thesis)
  • get_node_path -> get_path
  • VarNode -> ✅
  • remove_all_but! -> ✅
Whiteboard

Image