source maps should be enabled

Question

source maps should be enabled

klaemo opened this issue 9 years ago · comments

hey there!

By default hjs-webpack doesn't seem to enable source maps. Is there a good reason for that?
I figured out that I have to run webpack-dev-server -d to enable them, but maybe that should be documented somewhere?

It was confusing for me, because the line numbers in the dev tools console didn't make any sense and I figured a sophisticated setup like this would surely enable source maps by default.

Clemens Stolle · Answer 1 · Wed Sep 02 2015 03:45:54 GMT+0800 (China Standard Time)

Did some digging and found this https://webpack.github.io/docs/configuration.html#devtool

Maybe a sane default would be cheap-module-eval-source-map during development?

Luke Karrys · Answer 2 · Wed Sep 02 2015 04:08:50 GMT+0800 (China Standard Time)

@klaemo Yeah, that definitely seems like a better option for dev. In my usage I seem to have just never noticed that they weren't enabled but after enabling them manually in a small side project (that uses hjs-webpack+React+babel) the different is huge! We should definitely do this.

Luke Karrys · Answer 3 · Thu Sep 03 2015 02:36:43 GMT+0800 (China Standard Time)

Published as part of v2.13.0

Clemens Stolle · Answer 4 · Thu Sep 03 2015 03:31:27 GMT+0800 (China Standard Time)

Thanks! Gotta love open source ❤️