HdrHistogram / HdrHistogram_rust

A port of HdrHistogram to Rust

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Criterion data in repo

marshallpierce opened this issue · comments

Is it right that .criterion is checked in? It seems like it's using that as a baseline to compare against or something, which isn't applicable on my hardware. Also, presumably if you were benchmarking against a baseline, wouldn't you want to set the baseline on a particular revision, then apply the changes under consideration?

Yeah, Criterion is supposed to do regression testing whenever you run it, and it uses .criterion for this. And they advice that you should check it in. However, given how broken it currently is, plus the fact that it doesn't take into account running on different machines, I think we can just delete it.

Closed by #23.