HazyResearch / meerkat

Creative interactive views of any dataset.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Typo in setup.py for Cython dependency causes installation to sometimes fail

gtmtg opened this issue · comments

Hi! I believe there's a typo in setup.py around the Cython dependency. This:

    "semver>=2.13.0",
  > "multiprocess>=0.70.11" "Cython>=0.29.21",
    "progressbar>=2.5",

(source)

is missing a comma, causing the strings to be concatenated; it should be:

    "semver>=2.13.0",
    "multiprocess>=0.70.11",
    "Cython>=0.29.21",
    "progressbar>=2.5",

This is causing installation to fail in some cases (for some reason, with Poetry 1.2 or above but not with earlier versions of poetry) for us with an error like: "multiprocess: Could not parse version constraint: >=0.70.11Cython"

Sorry about the delay, we're dealing with a couple of paper deadlines. I just merged the fix you suggested (#264) into the dev branch. I recommend primarily using that branch, since it's easier for us to push fixes there quickly without doing a larger release (and we keep it stable).