Hasnayeen / invobook

Self-hosted app for Time Tracking, Invoice Generation, Project & Client Management, built with Laravel & Filament.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add edit option on message board (VueJS)

Hasnayeen opened this issue · comments

Add edit option for message in message board. api to use is message/{message_id}

Hello, I am taking this issue!

@thesanjeevsharma Sure, go ahead. But if you decide not to do this later on please mention on the issue so that other can pick it up.

@Hasnayeen discontinuing this; facing issues Laravel setup!

I‘d like to look into this topic today.

Sure, go ahead. But if you decide not to do this later on please mention on the issue so that other can pick it up.

First draft of my implementation.
I still have to get rid of one issue where the list of messages are not yet updated properly after editing even if the array of messages are changed in the way Vue expects it to be changed (meaning through their proxy methods) and not directly overwriting and element through accessing the Array through an index.

I fixed the rendering problem now and changed the v-for key ot message.body as the the id doesn't change when updating the message but the body does. This is also recommended in the VueJS documentation.

Thanks and best regards,
Jan

@ewatch thanks for the pr, nice work 👍