fix continuous integration build

Question

fix continuous integration build

HaithemMosbahi opened this issue 6 years ago · comments

Mosbahi Haithem commented 6 years ago

This is about fixing the travis build

Luiz Machado · Answer 1 · Tue Oct 02 2018 19:27:47 GMT+0800 (China Standard Time)

Just to reference for future: https://travis-ci.org/HaithemMosbahi/ngx-avatar

Luiz Machado · Answer 2 · Wed Oct 03 2018 06:20:01 GMT+0800 (China Standard Time)

Let's start with #40

Luiz Machado · Answer 3 · Wed Oct 03 2018 06:54:27 GMT+0800 (China Standard Time)

@HaithemMosbahi can you help me on that?

Chromium 62.0.3202 (Ubuntu 0.0.0): Executed 1 of 1 (1 FAILED) (0 secs / 0.092 secs)
Chromium 62.0.3202 (Ubuntu 0.0.0) AvatarComponent should create FAILED
	Error: StaticInjectorError(DynamicTestModule)[AvatarComponent -> SourceFactory]: 
	  StaticInjectorError(Platform: core)[AvatarComponent -> SourceFactory]: 
	    NullInjectorError: No provider for SourceFactory!

Mosbahi Haithem · Answer 4 · Wed Oct 03 2018 15:53:01 GMT+0800 (China Standard Time)

@odahcam yes sure, the service SourceFactory must be provided to avatar.component spec. I'm going to update the pull request

Luiz Machado · Answer 5 · Wed Oct 03 2018 19:49:33 GMT+0800 (China Standard Time)

And success: https://travis-ci.org/HaithemMosbahi/ngx-avatar/builds/436514474

Once this doesn't depends on any release to take effect, I'm closing it.