Cover the component with unit test

Question

Cover the component with unit test

HaithemMosbahi opened this issue 6 years ago · comments

In order to improve the component code and to reduce potential bugs and also to make it easy to maintain we need to cover the ngx-avatar component with unit test.

Mosbahi Haithem · Answer 1 · Wed Oct 03 2018 19:32:21 GMT+0800 (China Standard Time)

I'm working on this one, I started by refactoring / covering the avatar.service. Here's the branch

Mosbahi Haithem · Answer 2 · Mon Oct 29 2018 20:49:08 GMT+0800 (China Standard Time)

should be closed when this branch gets merged #46

Luiz Machado · Answer 3 · Thu Nov 01 2018 08:13:50 GMT+0800 (China Standard Time)

I think it's ready, isn't it?

Mosbahi Haithem · Answer 4 · Fri Nov 02 2018 21:53:34 GMT+0800 (China Standard Time)

I still need to cover some scenarios in the avatar.component.spec.ts
The goal is to cover the maximum features to avoid bugs / regression. I think after that we will be able to confidently auto publish to npm when we merge to master