Tooltip text on the icons.

Question

Tooltip text on the icons.

ashutoshshisodia opened this issue 4 years ago · comments

Feature description

There must be tooltip text on icons (when hovered) of ineligible repo, pending PR, etc in profile section. It is more convenient like that rather going at bottom and seeing the reference for the icons.
Please help me fix it. Suggest where should I start ?

Matt Cowley · Answer 1 · Tue Oct 06 2020 16:07:27 GMT+0800 (China Standard Time)

https://github.com/digitalocean/hacktoberfest/blob/0e0f9e022c1a820a4d7bf95d80610791d70e997b/app/views/users/show/pr/_pr.html.erb#L4-L6

https://github.com/digitalocean/hacktoberfest/blob/0e0f9e022c1a820a4d7bf95d80610791d70e997b/app/views/users/show/pr/_icon.html.erb#L1-L26

Reg · Answer 2 · Tue Oct 20 2020 20:33:01 GMT+0800 (China Standard Time)

Hi is this issue still available? I'd like to try and take this on if it hasn't been taken yet. :)

Matt Cowley · Answer 3 · Tue Oct 20 2020 22:46:26 GMT+0800 (China Standard Time)

@reginaalyssa Yeah, looks like it, go for it :)

Reg · Answer 4 · Wed Oct 21 2020 00:50:04 GMT+0800 (China Standard Time)

Awesome, will work on this! Is there any specific look we're going for on the tooltip or would it just be a regular grey background for both light and dark mode?

Matt Cowley · Answer 5 · Wed Oct 21 2020 01:03:31 GMT+0800 (China Standard Time)

Whatever you think looks/works best :)

Reg · Answer 6 · Wed Oct 21 2020 20:47:44 GMT+0800 (China Standard Time)

Got it! I've opened a pull request for this just now. I just have a few items I need some help on, mostly on tests. Thanks! :)

Ashutosh Shisodia · Answer 7 · Wed Oct 21 2020 20:59:42 GMT+0800 (China Standard Time)

Hey @reginaalyssa congratss!! and sorry @MattIPv4 I was greatly busy after creating the issue hence could not give time to it :( .