FAQ is outdated regarding new rules for pull requests
rupran opened this issue · comments
Describe the bug
With the change in #596, some items in the FAQ page are outdated.
To Reproduce
Steps to reproduce the behavior:
- Go to https://hacktoberfest.digitalocean.com/
- Click on 'FAQ'
- Scroll down to 'Rules'
- See (now) outdated information about the rules that apply to pull requests, at least for the points in the screenshot below (counting accepted/merged pull requests, any GitHub repository being good for PRs, tagging of issues/repostitories)
Expected behavior
The new rules are documented in the FAQ.
Screenshots
On a similar note, the Rules section on the homepage itself needs to be updated too.
Similarly, commit 8e9418b in PR #596 changed the review window from 7 days to 14 days. There are now multiple places in the site that need to be changed to reflect this. For example:
- The "Details" page has "There's a seven-day review window for all pull requests before they count toward completing the challenge." - https://github.com/digitalocean/hacktoberfest/blob/master/app/views/pages/details.html.erb#L121
- The "FAQ" page has "Once you have submitted four eligible PRs (ready-to-review, not drafts), the seven-day review window begins." - https://github.com/digitalocean/hacktoberfest/blob/master/app/services/airtable_placeholder_service.rb#L93
(emphasis added).
This is also the case on the front page:
How long are you going to run the event with outdated rules?
What about contributions those have done between backend update and documentation update? Are they lost unless target repository owners know about hacktoberfest?
My PRs are in Ineligible Repository status even documentation does not state about repository optin.
The PRs will show up on the profile will the relevant message explaining what is stopping them counting. As soon as the requirements are met, the PR will become valid.
The team are working on updating the FAQs and copy throughout the site -- our priority was getting the actual change out to start fighting the spam, we're now working to ensure all the copy matches the changes made, please have some patience whilst we work through it ('tis a Saturday).
The team are working on updating the FAQs and copy throughout the site -- our priority was getting the actual change out to start fighting the spam, we're now working to ensure all the copy matches the changes made, please have some patience whilst we work through it ('tis a Saturday).
How does backend change reduce spam if nobody knows about the change? Spammers don't read git changelogs to find out that rules have been changed.
The changes made so far include updates the onboarding/registration flow to make our position on spam clear -- we've also got https://hacktoberfest.digitalocean.com/hacktoberfest-update published which explains everything we're doing, which has been shared via our social channels.
As I noted in my previous reply, it is a Saturday and our team are working to update the copy on the site, please have some patience :)
The changes made so far include updates the onboarding/registration flow to make our position on spam clear -- we've also got https://hacktoberfest.digitalocean.com/hacktoberfest-update published which explains everything we're doing, which has been shared via our social channels.
I'm sorry I did not know I need to follow third party sites to find out if rules/faq are outdated.
Thank you for clarifying, @MattIPv4, and kudos for deploying such a huge change to the project on a Friday/Saturday.
I'm really sorry that this year's Hacktoberfest took such a negative turn right at the beginning, I still think it's a great idea to get people involved in open source, even if many people tried to game the system this year. I for myself found some really interesting projects through Hacktoberfest over the last years that I keep revisiting and submitting pull requests to (not just for Hacktoberfest).
All site copy has been updated 👍