Review Profile page for user in completed state
mkcode opened this issue · comments
We had temporarily used definite language for collecting swag for users you had completed hacktoberfest, but not yet collected a coupon: #286 (comment)
Once all coupons are loaded and being immediately redeemed, we should update this copy to reflect that they may or may not receive swag.
@MattIPv4 Once coupons are sent out this is the issue to track updating the completed page copy.
Just to check, as we're now allocating coupons real-time, the only time a user will see this page is when there isn't a coupon available?
Could they also end up seeing this page in a race-condition where two users hit the site at the exact same time, so we lock and don't allocate codes?
@MattIPv4 Yes, that's correct.
They could see this in some rare case, where there's a GitHub API failure or other failure in the transition step that happens on page load (like a StaleObjectError) but that's pretty unlikely at this point.
Completed in #380