Giters

Hack4Eugene / SpeedUpAmerica

Crowd-sourced internet speed tests using M-Lab data and user tests on a website, with charts, maps, and raw data downloads.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Get location detection working on Firefox (0.5SP)

noahbrenner opened this issue · comments

commented

Describe the bug
When running a speed test using Firefox, the page does not recognize that location access has been granted. (Accessing location data does work on Chrome.)

To Reproduce

  1. Start Firefox and go to the home page
  2. Click on the "Take the Test!!" button
  3. Select the "Use my browser's location" checkbox
  4. Click the "Get My Location" button
  5. Firefox will prompt for access -- Click the "Allow Location Access" button in Firefox's prompt
  6. See the bug: A modal pops up saying "Please enable Location!"
    • You can close the modal using the "Close Popup" button which leaves you at the same step where you would select a way to provide your location. (this is good)
    • "Use my browser's location" remains selected (this is good, I think)
    • You can try again to "Get My Location", which will trigger the browser prompt again for location access (this is good)

Expected behavior
The site makes use of the location provided by Firefox and continues to the next screen in the speed test process.

Tested on desktop:

  • OS & Version: Ubuntu 18.04.4 LTS
  • Browser: Firefox 77.0.1 (64-bit)

Additional context
I get the same bug whether using a Private window or a normal one.
Location detection works correctly on Chrome (both Incognito and normal).

If you're the one fixing this bug: Bonus points for checking additional browsers, though not required since this report is specific to Firefox.

commented

Changed to 0.5SP because we can only provide instructions for a browser issue. We can't actually fix it for website visitors. See the closing PR for details.