Release Classifieds.sol

Question

Release Classifieds.sol

alcueca opened this issue 4 years ago · comments

Alberto Cuesta Cañada commented 4 years ago

Rename Classifieds.sol as ClassifiedsAdvanced.sol.
Rename ClassifiedsV2.sol as Classifieds.sol and get it out of drafts.
Increase test coverage of the Classifieds.sol outside drafts until tests pass (90%?)

Alberto Cuesta Cañada · Answer 1 · Wed Jan 15 2020 22:31:44 GMT+0800 (China Standard Time)

We are still missing the README, could you please fix that?

Vlad Silviu Farcas · Answer 2 · Wed Jan 15 2020 22:48:03 GMT+0800 (China Standard Time)

Sure! By the way, we are also missing the README.md for ERC20Dividenable, I'll do one for that, too.

Vlad Silviu Farcas · Answer 3 · Wed Jan 22 2020 16:13:54 GMT+0800 (China Standard Time)

@albertocuestacanada Is this issue closable?

Alberto Cuesta Cañada · Answer 4 · Wed Jan 22 2020 19:41:11 GMT+0800 (China Standard Time)

The PR is closed, so yes.

There is some way to add the issue number in the PR (either at the end of the title or at the end of the description, not sure), and when the PR is merged the issue automatically closes. Let's find out how to do that.