Question about right handle when it's not moved
jeongbalmount opened this issue · comments
When the right handle is still and only the left handle is moved, the video is not played again but stops.
Is there any way to fix this?
Could you expand a bit please ? When you move a handle, the asset shows the image associated with the current position of the handle (to help you get a precise position for trimming), and playback should resume once you lift your finger up.
I know what you're talking about. What I want to say is that video does not repeat when the right handle is located at the end of the trimmer.
Not all videos are like this, but only a few videos seem to have this problem.
And if right handle moves at least once and go back to the end of the Trimmer, the video repeats itself.
Got it, thanks for the video, makes it clearer.
I currently don't have time to investigate this, but feel free to open a PR and I'll review it 🙏
Thanks! 👍
PR that fixes this: https://github.com/HHK1/PryntTrimmerView/pull/81/files
Sorry for the late reply! I changed the code and tested it, but it stops the same 😢 . And also same result in
PryntTrimmerViewExample.
I added observer to the part where I put AVasset in the AVplayer and added itemDidFinishPlaying to check if the player was stopped, did I applied wrong?
Hi @jeongbalmount if you are talking about the fix in my PR, since it has been merged you can just pull the newest code from this repo. You should not need to manually change code
I added swift Package(https://github.com/xaphod/PryntTrimmerView.git) but it didn't work. Is this not the right way to do it?
I was really stupid! I declared a new Notification name 😅 (AVPlayerItemDidPlayToEndTime)
Thanks @xaphod!!