Giters

HCL-TECH-SOFTWARE / digital-experience

Next-generation documentation site for HCL Digital Experience.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect documentation for pullsecrets as of CF206

DanieleVistalli opened this issue · comments

commented

digital-experience/docs/deployment/install/container/helm_deployment/preparation/optional_tasks/optional_imagepullsecrets.md

Line 17 in 181d35f

- name: regcred

Documentation suggets using:

images:
  imagePullSecrets: 
  - name: "secretname"

this fails when appied to template.

The working syntax for CF206 is

images:
  imagePullSecrets: 
  - "secretname"
commented

Actaully after more investigation this is failing if

global.hclImagePullSecret is not null.

This created confusion. It would be better to deprecate / remove and check the value of hclImagePullSecret to ensure it is null (even if I don't get why it makes other secrets fail).

commented 
images:
  imagePullSecrets: 
  - name: "secretname"

should be the correct input. we will update the validation for this in one of the upcoming releases.

The error when setting both imagePullSecrets and global.hclImagePullSecret is a bug and will be fixed as well. global.hclImagePullSecret is required for SoFy deployments.

commented

this should not fail anymore in CF210