Please unify variable guid and the usage of variables in invite config
marde16 opened this issue · comments
The setup_invite_config tasks already use a variable for the ldap guid called ldap_guid_field
( and there is a ldaps port called ldap_ssl_port
)
Unfortunately these variables aren't documented in the variables overview - why I defined ldap_map_guid
variable in my PR ( #293 )
In my opinion here it needs some steps for a standardization:
-
add var
__ldap_ssl_port
to vars__ldap_ssl_port: "{{ (ldap_ssl_port | default('636')) }}"
and replace
ldap_ssl_port | default('636')
with__ldap_ssl_port
-
add var
__ldap_map_guid
to vars__ldap_map_guid: "{{ ldap_map_guid | default('entryUUID') }}"
and replace
ldap_guid_field | default('entryUUID')
with__ldap_map_guid
-
replace
ldap_guid_field | default('entryUUID')
with__ldap_map_guid
-
finally update missing vars in variable overview page
... and the variable ldap_ssl_port
can be used in the issue " LDAP ports hardcoded #276 ", too.