File not found exception when picking file from downloads

Question

File not found exception when picking file from downloads

saurabhsbora opened this issue 4 years ago · comments

Whenever I select any file from downloads with filename containing spaces, it is giving me an error file not found exception & also a toast in a different language. Please provide a fix for this.

I have the traced the issue - it is due to invalid characters in the filename and we need to replace them with an underscore.

Android -10

Hagen Brooks · Answer 1 · Sun Aug 09 2020 15:36:12 GMT+0800 (China Standard Time)

What is the path that gets returned and what is the file name?

Please provide a screenshot using the demo application.

Saurabh Bora · Answer 2 · Sun Aug 09 2020 21:01:01 GMT+0800 (China Standard Time)

@HBiSoft I cannot capture the screenshot using the demo application as the downloads folder is disabled.

Hagen Brooks · Answer 3 · Sun Aug 09 2020 21:38:45 GMT+0800 (China Standard Time)

the downloads folder is disabled

I tested and I was able to select a file from the downloads folder.

Anyway, what is the file path that gets returned?

Saurabh Bora · Answer 4 · Mon Aug 10 2020 14:56:17 GMT+0800 (China Standard Time)

Anyway, what is the file path that gets returned?

@HBiSoft
Returned path by PickiT

E/RETURNED -: /storage/emulated/0/Download/Screenshot (94).png
This path is not found when you try to create a file object as the actual file name is screenshot__94_.png

You can reproduce the issue by renaming the file with spaces or brackets and then check if the file exists using File Object.
We need to explicitly replace those characters with an underscore and it works.

Hagen Brooks · Answer 5 · Mon Aug 10 2020 15:54:16 GMT+0800 (China Standard Time)

I tested this by selecting a file with the following name - VID 2019__1234_.mp4
PickiT returned the following path - /storage/emulated/0/Download/VID 2019__1234_.mp4

I tested this:

File mFile = new File(pathReturnedByPickiT);
if (mFile.exist){
    Log.e("File", "was found");
}

and the log gets called.

Can you please provide me with the Uri that gets returned in onActivityResult - data.getData();?

Saurabh Bora · Answer 6 · Mon Aug 10 2020 20:46:46 GMT+0800 (China Standard Time)

Can you please provide me with the Uri that gets returned in onActivityResult - data.getData();?
@HBiSoft
Uri - content://com.android.providers.downloads.documents/document/475

Sugat Mankar · Answer 7 · Tue Aug 11 2020 00:50:05 GMT+0800 (China Standard Time)

If i download an zip and extracted it in Download folder
Download
|__Extracted
|_File1
|_File2

In this case if i selected File1

It returns /storage/emulated/0/Download/File1

It should have returned /storage/emulated/0/Download/Extracted/File1

Hagen Brooks · Answer 8 · Tue Aug 11 2020 21:13:48 GMT+0800 (China Standard Time)

@enthussb
Thats very strange because I'm not replacing characters in the file name.
Please try the following and see what name gets returned:

@SuppressWarnings("TryFinallyCanBeTryWithResources")
private static String getFilePath(Context context, Uri uri) {
    Cursor cursor = null;
    final String[] projection = {MediaStore.Files.FileColumns.DISPLAY_NAME};
    try {
        cursor = context.getContentResolver().query(uri, projection, null, null, null);
        if (cursor != null && cursor.moveToFirst()) {
            final int index = cursor.getColumnIndexOrThrow(MediaStore.Files.FileColumns.DISPLAY_NAME);
            return cursor.getString(index);
        }
    }catch (Exception e) {
        e.printStackTrace();
    } finally {
        if (cursor != null)
            cursor.close();
    }
    return null;
}

Hagen Brooks · Answer 9 · Tue Aug 11 2020 21:16:55 GMT+0800 (China Standard Time)

@sugatmankar
Are you using the latest version? I remember fixing this in an earlier release.
If you are using the latest version, please open a new issue and provide as much info as possible.
Thanks.

Saurabh Bora · Answer 10 · Wed Aug 12 2020 14:14:10 GMT+0800 (China Standard Time)

@enthussb
That's very strange because I'm not replacing characters in the file name.
Please try the following and see what name gets returned:

@HBiSoft
This is the name returned by that function -

The original name in the file manager -

Currently, I am facing this issue only when I pick any file from downloads.
To reproduce this issue please pick any file having spaces or other reserved characters in filename from the downloads folder when you open the intent and not by going through file manager -> downloads -> file

Hagen Brooks · Answer 11 · Wed Aug 12 2020 15:40:21 GMT+0800 (China Standard Time)

@enthussb
I'm not able to reproduce this.
Please provide me your entire Intent, so that I can test it as you have it.

Saurabh Bora · Answer 12 · Wed Aug 12 2020 17:14:12 GMT+0800 (China Standard Time)

@HBiSoft

Please provide me your entire Intent, so that I can test it as you have it.

final String[] ACCEPT_MIME_TYPES = {
                "application/pdf",
                "image/*"
        };
        Intent intent = new Intent()
                .setType("*/*")
                .setAction(Intent.ACTION_OPEN_DOCUMENT)
                .addCategory(Intent.CATEGORY_OPENABLE)
                .putExtra(Intent.EXTRA_MIME_TYPES, ACCEPT_MIME_TYPES);
        startActivityForResult(intent, REQUEST_SELECT_FILE);

Hagen Brooks · Answer 13 · Wed Aug 12 2020 21:08:18 GMT+0800 (China Standard Time)

I tested once more and I still was not able to reproduce this.
I'm not sure if the following will give the correct name, but it's worth the try, please let me know if the correct name is returned:

@SuppressWarnings("TryFinallyCanBeTryWithResources")
private static String getFilePath(Context context, Uri uri) {
    Cursor cursor = null;
    try {
        cursor = context.getContentResolver().query(uri, null, null, null, null);
        if (cursor != null && cursor.moveToFirst()) {
            final int index = cursor.getColumnIndexOrThrow(OpenableColumns.DISPLAY_NAME);
            return cursor.getString(index);
        }
    }catch (Exception e) {
        e.printStackTrace();
    } finally {
        if (cursor != null)
            cursor.close();
    }
    return null;
}

Saurabh Bora · Answer 14 · Thu Aug 13 2020 01:10:11 GMT+0800 (China Standard Time)

@HBiSoft
I tested with the above code and still, I got the same name as the display name whereas the original name should have spaces replaced with underscores, or else it will give file not found exceptions.

Hagen Brooks · Answer 15 · Thu Aug 13 2020 02:15:52 GMT+0800 (China Standard Time)

Can you please explain what you meant with the following:

I cannot capture the screenshot using the demo application as the downloads folder is disabled.

Also, you said the following:

from the downloads folder when you open the intent and not by going through file manager -> downloads -> file

I assume you meant that after launching the intent -> Files - Downloads - screenshot__94_.png?

Saurabh Bora · Answer 16 · Thu Aug 13 2020 13:37:39 GMT+0800 (China Standard Time)

@HBiSoft

Can you please explain what you meant with the following:

It is the same as #2 Whenever I try to pick a file from downloads using PickIt I am unable to do that as all the files are disabled there.

I assume you meant that after launching the intent -> Files - Downloads - screenshot__94_.png?

There are two ways to go to downloads -

As shown in the below picture
By manually traversing through Internal Storage -> Downloads (File manager basically)

Whenever I pick a file having spaces or bracket in its name from downloads using the first method I am getting File not found exception.

Hope this will make it clear.

Hagen Brooks · Answer 17 · Thu Aug 13 2020 13:46:38 GMT+0800 (China Standard Time)

@enthussb

It is the same as #2 Whenever I try to pick a file from downloads using PickIt I am unable to do that as all the files are disabled there.

No, video files are not disabled. In the demo application intent.setType("video/*"); is passed to the Intent.
I wanted you to test with the demo application (by selecting a video) to see if the problem might be with the Intent.
Instead of selecting an image, rename a video inside your downloads folder to a similar name and test it again.

Hope this will make it clear.

Yes, I tested both ways.

Saurabh Bora · Answer 18 · Thu Aug 13 2020 15:12:51 GMT+0800 (China Standard Time)

@HBiSoft The issue is if you rename it from your file manager it will work as it corrects the file name. Could you provide me your email so that I can send you the image there and then after downloading it you can check the issue?

Hagen Brooks · Answer 19 · Thu Aug 13 2020 15:49:53 GMT+0800 (China Standard Time)

@enthussb

The issue is if you rename it from your file manager it will work as it corrects the file name.

No, the issue is that an incorrect name is given when querying the DISPLAY_NAME column (this is not related to the library) and we will not be able to fix it afterwards (by renaming it) because how will we know that the name is incorrect..

I wanted you to test with the demo application (by selecting a video) to see if the problem might be with the Intent.
Instead of selecting an image, rename a video inside your downloads folder to a similar name and test it again.

Did you test this?

Could you provide me your email so that I can send you the image there and then after downloading it you can check the issue?

Sure here is my email - contact.hbisoft@gmail.com

PS. I did rename an image to screenshot__94_.png and selected if from the Downloads folder as you mentioned in #25 (comment)

Saurabh Bora · Answer 20 · Fri Aug 14 2020 20:34:24 GMT+0800 (China Standard Time)

@HBiSoft I checked with what you said and it works as file is renamed using the file manager but the problem which I am facing is different & I am unable to explain to you right now. Closing this temporarily