Run js minifier on <script> content in html minifier

Question

Run js minifier on <script> content in html minifier

GuillaumeGomez opened this issue 7 years ago · comments

Guillaume Gomez commented 7 years ago

Corey Farwell · Answer 1 · Mon Apr 24 2017 23:09:22 GMT+0800 (China Standard Time)

I don't think you can assume that everything inside <script> is JavaScript

Guillaume Gomez · Answer 2 · Mon Apr 24 2017 23:12:38 GMT+0800 (China Standard Time)

Only on type=text/javascript I suppose. The same goes for <style>.

Corey Farwell · Answer 3 · Mon Apr 24 2017 23:26:31 GMT+0800 (China Standard Time)

I don't think you can make any assumptions about the body of <script> or <style>. Even if I do <script type='text/javascript'> one can still put invalid JavaScript in there

Guillaume Gomez · Answer 4 · Mon Apr 24 2017 23:27:41 GMT+0800 (China Standard Time)

Hum, I guess. Would be great though...

Corey Farwell · Answer 5 · Mon Apr 24 2017 23:29:12 GMT+0800 (China Standard Time)

In general, I suggest copying what other minifiers are doing instead of making up what you think works. I also suggest copying their test cases.