Opening up ConnectionPoolSettings in AddWebSocketExecutor method

Question

Opening up ConnectionPoolSettings in AddWebSocketExecutor method

javaadpatel opened this issue 5 years ago · comments

Hi,
I've been trying some load testing on my graph to check whether I'm modelling my data effectively, and I ran into this exception:

I saw there is a connectionPoolSetting that could be exposed in the AddWebSocketExecutor method, shown here:

Could I make a PR to expose this setting? This would allow users to set their own connection PoolSize and MaxInProcessPerConnection settings instead of having to use the defaults.

Daniel Weber · Answer 1 · Tue Sep 10 2019 02:04:10 GMT+0800 (China Standard Time)

I wouldn't currently accept such a PR because it would make the abstraction leak. I recognize the issue here though.

Javaad Patel · Answer 2 · Fri Nov 01 2019 16:11:10 GMT+0800 (China Standard Time)

What is the best way to get around this error? I am now experiencing it in my production environment as the load is too great. I am using a singleton of IConfigurableGremlinQuerySource and then using that to execute all the queries

Javaad Patel · Answer 3 · Mon Nov 04 2019 02:35:17 GMT+0800 (China Standard Time)

I see there's actually a way to pass a Func<IGremlinClient> clientFactory to the .AddWebSocketExecutor method and that allows you to control all the settings actually.