GoogleCloudPlatform / professional-services

Common solutions and tools developed by Google Cloud's Professional Services team. This repository and its contents are not an officially supported Google product.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Flag for using private IP is wrong

jiya-zhang opened this issue · comments

In the README file, to instruct users to avoid using public IP for their job, it says:
Screenshot 2023-01-04 at 11 02 49 AM

However, according to the documentation, the flag --use_public_ips=false should be --no_use_public_ips. Note that please check the flag documentation for Python specifically.

@jiya-zhang To which README file does this apply?

@jiya-zhang Thanks for flagging this. Indeed, this parameter has changed in Dataflow, I added a PR to update this detail accordingly in the project: examples/dataflow-data-generator I guess this is the project you were referring to (couldn't find usage of this parameter anywhere else.

For future issues, please make sure to mention the tool or example folder path that you're referring to e.g. examples/your-example etc..