GoogleCloudPlatform / app-gradle-plugin

The repository sources are misleading:

Line 14 in 1d3084f

| 2.0.0 + | 4.0 or newer |

app-gradle-plugin/src/main/java/com/google/cloud/tools/gradle/appengine/AppEnginePlugin.java

Line 37 in 1d3084f

    
           private static final GradleVersion GRADLE_MIN_VERSION = GradleVersion.version("3.4.1");

app-gradle-plugin/src/main/java/com/google/cloud/tools/gradle/appengine/core/AppEngineCorePluginConfiguration.java

Line 35 in 1d3084f

    
           public static final GradleVersion GRADLE_MIN_VERSION = GradleVersion.version("3.4.1");

Thank you for catching this - I believe the README has the intended version compatibility here, and we likely missed updating GRADLE_MIN_VERSION used in the enforcement check and test suite. Will put in a PR for aligning them. (This may also need to be re-visited after #451, as you noted.)

@emmileaf thanks. Implementation-wise I would actually merge #451 first, and then move the constant to GradleCompatibility class so there's only one, not two of them.

Implementation-wise I would actually merge #451 first, and then move the constant to GradleCompatibility class so there's only one, not two of them.

That's a good suggestion - I'll unlink #453 and leave this issue open to track follow-ups needed.

Question: What is the minimum supported Gradle version?