GoogleChromeLabs / pwacompat

PWACompat to bring Web App Manifest to older browsers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unable to set `black-translucent`

ardatan opened this issue · comments

First of all, thank you for this great plugin. It actually solves the splash screen problem of my PWA.

I have a little issue on iOS.
According to Apple docs, you can set transparent status bar which is not possible with pwacompat.
https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html
pwacompat only sets black or default according to theme option.

Thanks. I think this is tricky because it might overlap folks' content, which is not what they expect, but maybe it makes sense for (at least) fullscreen.

I'll do some testing and do something in the next release 👍

+1 on this.

Right now it seems, we can have either get a splash-screen or 'black-translucent' status bar in fullscreen. Especially on the iPhoneX[rs, etc..] it would be nice, if we could have both :)

Otherwise: Awesome work! Thanks!

(btw: I just replaced 'black' with 'black-translucent' in the code and that seems to work fine - so at least it's possible ;) )

I've thought about this and come up with a PR. Can you take a look? @tiptronic @ardatan

Resolved by #21.

Thank you very much!

Sorry for the delay. I've pushed 2.0.8 now which includes this.